Merged
Conversation
✅ Deploy Preview for rsbuild ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enables Vitest’s global APIs by configuring TypeScript to recognize vitest/globals and removing explicit vitest imports from setup and test files.
- Add
"types": ["vitest/globals"]to test-relatedtsconfig.jsonfiles - Remove redundant
describe,it,expect,beforeAll, andviimports in setup and tests
Reviewed Changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| scripts/test-helper/vitest.setup.ts | Removed explicit Vitest imports to use global APIs |
| scripts/test-helper/tsconfig.json | Added "types": ["vitest/globals"] to enable globals |
| packages/plugin-svgr/tests/tsconfig.json | Added "types": ["vitest/globals"] |
| packages/plugin-svgr/tests/index.test.ts | Removed redundant Vitest imports |
| packages/plugin-react/tests/tsconfig.json | Added "types": ["vitest/globals"] |
| packages/plugin-react/tests/index.test.ts | Removed redundant Vitest imports |
| packages/plugin-react/tests/features.test.ts | Removed redundant Vitest imports |
| packages/plugin-preact/tests/tsconfig.json | Added "types": ["vitest/globals"] |
| packages/plugin-preact/tests/index.test.ts | Removed redundant Vitest imports |
| packages/plugin-babel/tests/tsconfig.json | Added "types": ["vitest/globals"] |
| packages/plugin-babel/tests/index.test.ts | Removed redundant Vitest imports |
| @@ -0,0 +1,8 @@ | |||
| { | |||
There was a problem hiding this comment.
[nitpick] Test tsconfig files across multiple packages are nearly identical. Consider extracting a shared base tsconfig (e.g., tsconfig.tests.json) and having each package extend it to reduce duplication.
chenjiahan
approved these changes
May 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
use test global APIs.
https://vitest.dev/config/#globals
Related Links
Checklist